Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle Shout used from various tbc trash npcs should not stack #700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miraco
Copy link
Contributor

@miraco miraco commented Oct 9, 2024

🍰 Pullrequest

Battle Shout should not be stackable.

Issues

Using Ethereal Crypt Raider as example here:
This npcs can use Battle Shout on their self. Pulling multiple npcs of this type can result in overstacking Battle Shout.
Wow_eM1jdiM3z9

Tests on retail showed that they use it on their self even if they have the Buff (refreshing timer from 1min to 2 minutes)

How2Test

  • None

Todo / Checklist

  • None

@killerwife
Copy link
Contributor

I know that this code change works since grz3s tried to do similar, but this is not the actual fix. This just makes it incompatible cos a StackAmount check is done against other auras, and if they dont equal, they arent considered the same.

I will check what the current way of doing it is and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants