Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify examples by updating to new default loop #34

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Aug 2, 2021

This changeset simplifies usage by using the new default loop.
Builds on top of reactphp/event-loop#229, reactphp/event-loop#232 and reactphp/stream#159

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this!

},
"require-dev": {
"phpunit/phpunit": "^9.3 || ^5.7 || ^4.8",
"react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3"
"react/event-loop": "^1.2"
Copy link
Owner

@clue clue Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the updated examples reference the event loop at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event loop is still necessary for some tests (see FunctionalControlCodeParserTest.php).

@clue clue added this to the v1.4.0 milestone Aug 2, 2021
@SimonFrings SimonFrings changed the title Simplify usage by supporting new default loop Simplify examples by updating to new default loop Aug 3, 2021
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit f9c0b6c into clue:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants