Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.3 and update test suite #113

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 14, 2023

This pull request builds on top of #108 #107 and #105.

References: clue/reactphp-csv#33, reactphp/socket#300 and reactphp/socket#299.

After this pull request is merged, we can continue with #112

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing this pull request 👍

I added a few remarks below, should both be quick fixes.

I also noticed that the test suite currently reports unhandled promise rejections in this project (see reactphp/promise#248 and https://github.com/orgs/reactphp/discussions/525 for reference), but I think this is something for a follow-up PR. I will look into this.

phpunit.xml.dist Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@SimonFrings SimonFrings added documentation Improvements or additions to documentation new feature and removed documentation Improvements or additions to documentation labels Nov 14, 2023
@yadaiio
Copy link
Contributor Author

yadaiio commented Nov 14, 2023

Tysm @SimonFrings for seeing both mistakes! Helps me a lot for the future. 🥳 Should be alright now!

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes, looking good 👍

@SimonFrings SimonFrings added this to the v1.5.0 milestone Nov 14, 2023
phpunit.xml.dist Show resolved Hide resolved
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for filing this PR!

I've updated the PR to no longer report any deprecations as reported in #114. This PR now no longer reports any test errors and focuses on adding PHP 8.3 only.

I'll file separate follow-up PRs to address the deprecations reported in #114 and the unhandled promise rejections reported in #115.

@clue clue merged commit c54e663 into clue:1.x May 27, 2024
28 checks passed
@yadaiio
Copy link
Contributor Author

yadaiio commented May 28, 2024

Thank you @clue for the update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants