Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use full namespace so the example is runnable #112

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Use full namespace so the example is runnable #112

merged 1 commit into from
Jun 15, 2021

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Jun 12, 2021

Just a minor

@clue clue added this to the v2.5.0 milestone Jun 14, 2021
clue
clue reviewed Jun 14, 2021
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nyholm Thanks for the update, makes perfect sense! May I ask you to squash your changes into one commit?

@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 15, 2021

Thank you for the feedback. I've squashed the commits.

clue
clue approved these changes Jun 15, 2021
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nyholm Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit b2d8913 into clue:master Jun 15, 2021
@clue clue mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @clue