Make loop optional #110
Make loop optional #110
Conversation
There was a problem hiding this comment.
@WyriHaximus Thanks for bringing this up, this definitely helps reviewing reactphp/event-loop#226 and seeing its real-world impact on existing code!
I think making the LoopInterface optional and having it default to the global loop makes perfect sense. This definitely helps with making the code more streamlined and at the same time also avoids any BC breaks with existing consumers (unlike #109).
As such, I think the changes suggested in here make perfect sense as-is once the upstream PR merged. If anything, I would like to see a way to simplify Loop::get()->run() (and friends) in the examples, but I think this is also best discussed in the upstream PR.
For the reference, the build errors are unrelated to the changes in this PR. I'll look into an update to address this asap 👍
No description provided.