-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on PHPUnit 9 and simplify test matrix #23
Conversation
tests/TestCase.php
Outdated
parent::setExpectedException($exception, $exceptionMessage, $exceptionCode); | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: whitespace
tests/TestCase.php
Outdated
@@ -41,6 +41,30 @@ protected function expectCallableNever() | |||
|
|||
protected function createCallableMock() | |||
{ | |||
return $this->getMockBuilder('stdClass')->setMethods(array('__invoke'))->getMock(); | |||
if (method_exists('PHPUnit\Framework\MockObject\MockBuilder', 'addMethods')) { | |||
// PHPUnit 10+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPUnit 10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clue 👍
0306c8f
to
b59d044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonFrings Thanks for the update, changes LGTM!
No description provided.