Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage by supporting new default loop #33

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Conversation

SimonFrings
Copy link
Contributor

This pull request is a follow up for #32. Thanks to @PaulRotmann for investing time into this 👍.

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$connector = new ConnectionManagerTimeout($connector, 3.0, $loop);
$delayed = new ConnectionManagerDelayed($connector, 0.5, $loop);

// new (using default loop)
$connector = new ConnectionManagerTimeout($connector, 3.0);
$delayed = new ConnectionManagerDelayed($connector, 0.5);

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229 and reactphp/event-loop#232.

Resolves and Closes #32.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings and @PaulRotmann Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v1.3.0 milestone Sep 3, 2021
@clue clue merged commit 85fdea5 into clue:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants