Simplify App
by always using default loop, drop optional loop instance
#88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset simplifies the
App
by removing the optional$loop
argument and always using the default loop. Among others, this simplifies usage, improves the API documentation, removes a bunch of ambiguous tests, and overall helps clean up the project. Overall, we have yet to see a use case that requires an explicit loop instance and given that fibers require a single, shared loop instance anyway (reactphp/async#15), it's unlikely we'll find many use cases for this.This is obviously a BC break for consumers that currently explicitly pass a loop instance, but it is believed that this should not affect most consumers of this package. If you are affected, updating this is very straightforward:
Builds on top of #22, #29 and #81