Skip to content

Update documentation for Dockerfile syntax to avoid BuildKit warnings #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update documentation for Dockerfile syntax to avoid BuildKit warnings #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/best-practices/deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,10 +558,10 @@ be achieved by using a `Dockerfile` with the following contents:
COPY public/ public/
COPY vendor/ vendor/

ENV X_LISTEN 0.0.0.0:8080
ENV X_LISTEN=0.0.0.0:8080
EXPOSE 8080

ENTRYPOINT php public/index.php
ENTRYPOINT ["php", "public/index.php"]
```

=== "Dockerfile for minimal production image"
Expand Down Expand Up @@ -589,7 +589,7 @@ be achieved by using a `Dockerfile` with the following contents:
# COPY src/ src/
COPY --from=build /app/vendor/ vendor/

ENV X_LISTEN 0.0.0.0:8080
ENV X_LISTEN=0.0.0.0:8080
EXPOSE 8080

USER nobody:nobody
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/Dockerfile-basics
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ WORKDIR /app/
COPY public/ public/
COPY vendor/ vendor/

ENV X_LISTEN 0.0.0.0:8080
ENV X_LISTEN=0.0.0.0:8080
EXPOSE 8080

ENTRYPOINT php public/index.php
ENTRYPOINT ["php", "public/index.php"]
2 changes: 1 addition & 1 deletion tests/integration/Dockerfile-production
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ COPY public/ public/
# COPY src/ src/
COPY --from=build /app/vendor/ vendor/

ENV X_LISTEN 0.0.0.0:8080
ENV X_LISTEN=0.0.0.0:8080
EXPOSE 8080

USER nobody:nobody
Expand Down