Refactor reactive server logic into new ReactiveHandler
#224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
reviewed
Apr 17, 2023
Contributor
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Found two typos, rest looks good 👍
SimonFrings
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset refactors the reactive server logic into a new internal
ReactiveHandler. This should not otherwise affect the public APIs or outside behavior in any way.This is a starting point to add more options to control the reactive server, application logging, access logging and more in follow-up PRs.
Builds on top of #222, #221, #44 and others