Add tests for Dockerfile instructions
#149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds some additional tests for the
Dockerfileinstructions recently added to our documentation. Special care is taken to ensure theDockerfileinstructions in the tests are very close to the documentation, so the CI setup contains a number of steps that wouldn't be needed otherwise. Ensuring the instructions are actually identical to the documentation (and stay so over time) is left up for a follow-up PR (PRs welcome!).Builds on top of #136 and #148
Supersedes / closes #147 which uses a more complex approach to ensure the
Dockerfileinstructions are identical to the documentation (but somewhat artificial for the test suite)Also done in preparation for signal handling as discussed in #144
Tests inspired by clue/reactphp-sqlite#55 and others