Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with aeson-2.0 #16

Closed
Tracked by #2328
sjakobi opened this issue Oct 9, 2021 · 4 comments · Fixed by #17
Closed
Tracked by #2328

Compatibility with aeson-2.0 #16

sjakobi opened this issue Oct 9, 2021 · 4 comments · Fixed by #17

Comments

@sjakobi
Copy link
Contributor

sjakobi commented Oct 9, 2021

See https://hackage.haskell.org/package/aeson-2.0.0.0/changelog.

If I use --allow-newer to build aeson-yaml with aeson-2.0.0.0, I get this error:

src/Data/Aeson/Yaml.hs:92:59: error:
    • Couldn't match type ‘Data.Aeson.KeyMap.KeyMap Value’
                     with ‘HashMap.HashMap Text Value’
      Expected type: HashMap.HashMap Text Value
        Actual type: Object
    • In the first argument of ‘HashMap.toList’, namely ‘hm’
      In the second argument of ‘($)’, namely ‘HashMap.toList hm’
      In the second argument of ‘map’, namely
        ‘(sortOn fst $ HashMap.toList hm)’
   |
92 |         map (keyValue level) (sortOn fst $ HashMap.toList hm)
   |                                                           ^^
@patrickmn
Copy link
Member

Uh oh. Thanks for fixing it! Will look at the quoting issue and issue a release hopefully tomorrow.

@sjakobi
Copy link
Contributor Author

sjakobi commented Nov 9, 2021

@patrickmn, I'd appreciate a release, no matter what the status of that quoting issue is. :)

@patrickmn
Copy link
Member

Ack, really sorry this took so long, Simon. I had a dream about doing this!

Released aeson-yaml-1.1.0.1 now. (Not sure if that's the correct application of PvP in this case.)

@sjakobi
Copy link
Contributor Author

sjakobi commented Nov 14, 2021

Thank you, @patrickmn! And no worries! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants