[WIP]fix: shard queue panic #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantxie
force-pushed
the
fix/shrad_queue_panic
branch
2 times, most recently
from
34330bf
to
f98dffa
Compare
jayantxie
force-pushed
the
fix/shrad_queue_panic
branch
from
f98dffa
to
11d37e7
Compare
ppzqh
reviewed
Apr 26, 2023
| } | ||
|
|
||
| // MUST decrease bufNum first. | ||
| if atomic.AddInt32(&q.bufNum, negBufNum) <= 0 && atomic.LoadInt32(&q.state) != active { |
succulentxb
reviewed
Jun 5, 2023
| } | ||
| negBufNum -= int32(len(q.swap)) |
There was a problem hiding this comment.
这里为什么是 -= len(q.swap) 呢？ bufNum 每增加一次，对应的 shard 中不一定只写入了一个 getter 吧，这样似乎 negBufNum != -bufNum ?
另外请问下这份PR还会继续维护吗？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
由于root cause并非这个原因，暂时pending
(Optional) Which issue(s) this PR fixes:
cloudwego/kitex#913
(optional) The PR that updates user documentation: