-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: support for Windows #191
base: revert-178-feat/adjust_windows
Are you sure you want to change the base?
WIP: feat: support for Windows #191
Conversation
Added cross-platform type abstractions, such as fdtype, etc. It encapsulates system calls under the windows platform, such as sendmsg, etc. Under the windows platform, an interface similar to epoll is implemented by encapsulating WSAPoll Completed cross-platform porting for Poll Make the project not report errors under the windows platform The corresponding test cases are modified to support cross-platform testing without changing their functions The implementation of Poll and the following passed the unit test TODO: Cross-platform implementation and testing of listener
…t errors under Windows
…efactor/support_for_windows
|
hi,同学你好,感谢对 netpoll 的大功能贡献 ~ 我大致看了下,PR 内容确实有点多,所以我觉得我们可以先在 PR 风格 和 代码风格 上达成一些共识,方便 PR 的 review:
以上,感谢 ~ |
1 后续会注意的,后续的修改会尽量将拆分为功能明确且较短的commit,方便review |
感谢 ~, 先开发吧,最后阶段再整理下 commit,比如 fix,debug 之类移除就好了 |
…ucceed and epoll wait would change the state of the event
What type of PR is this?
feat
What this PR does / why we need it (en: English/zh: Chinese):
en: This pr is an adaptation modification made to netpoll in order to complete the GLCC competition title "providing windows support for kitex".
Changes made so far:
What needs to be done next:
zh: 此pr是为了完成GLCC赛题“对kitex提供windows支持”而对于netpoll进行的适配性修改,目的是能够使得netpoll支持windows平台,目前是截至中期考核进行的一些成果。
到目前为止已经进行的改动:
接下来需要完成的:
Which issue(s) this PR fixes:
Fixes cloudwego/kitex#469