test(gRPC): remove redundant unit tests #1631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMwangnima
force-pushed
the
test/better_grpc_testing_prompt
branch
from
a1c3ebb to
7540c58
Compare
DMwangnima
commented
Dec 2, 2024
| }, | ||
| } | ||
| server, client := setUpWithOptions(t, 0, serverConfig, suspended, ConnectOptions{ | ||
| // FIXME the original ut don't contain KeepaliveParams |
There was a problem hiding this comment.
应该是理解错了这个单元测试的用意，整个流程是由 server 来主动发送 Ping，client 不需要主动发，所以不需要配置 KeepAlive 参数
ppzqh
previously approved these changes
Dec 2, 2024
xiaost
reviewed
Dec 2, 2024
|
|
||
| // grpcLogger is used to add test case information to assist in troubleshooting problems. | ||
| // it relies on testNameKey:testcase kv in ctx. | ||
| type grpcLogger struct { |
There was a problem hiding this comment.
正常情况下，如果单测没问题的话，go test ./... 是会跳过输出的，看不懂这个的用意是什么。我看相关的单测也不是并发的，有什么问题？
There was a problem hiding this comment.
单测出了问题的话，打出来的 Log 就比较混乱了，不好排查问题，这是一个示例：
DMwangnima
force-pushed
the
test/better_grpc_testing_prompt
branch
from
80ab0ff to
2c729a1
Compare
DMwangnima
force-pushed
the
test/better_grpc_testing_prompt
branch
from
37da49f to
aba6a07
Compare
DMwangnima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
test
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: