[WIP] fix(gRPC): retrieve status or biz error for non-ServerStreaming #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMwangnima
force-pushed
the
fix/retrieve_status_code
branch
from
3f8df3e to
ed9a54f
Compare
DMwangnima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
ClientStreaming 场景下，server 侧调用
SendAndClose后，可能还会 return 一个 err，例如：在当前的 client 侧，调用
CloseAndRecv后，只能拿到resp，但拿不到这个 err。然而在官方 gRPC 中是可以拿到这个 err 的。根本原因在于当前 Kitex 每次 Read 都只能解析一个 Frame，但实际上在 ClientStreaming 场景，这次 Read 不仅需要读 Data Frame，还需要读 Trailer Frame。
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: