feature/go-support

.travis.yml

@@ -31,17 +31,10 @@ jobs:
     script: sbt 'set concurrentRestrictions in Global += Tags.limitAll(1)' test
 
   - name: go tests
-    install:
-      - curl -L https://github.com/google/protobuf/releases/download/v3.9.1/protoc-3.9.1-linux-x86_64.zip -o /tmp/protoc-3.9.1-linux-x86_64.zip
-      - unzip /tmp/protoc-3.9.1-linux-x86_64.zip -d "$HOME"/protoc
-      - eval "$(gimme 1.13)" && go env
-      - go get -u github.com/golang/protobuf/protoc-gen-go
-    env:
-      - PATH=$HOME/protoc/bin:$PATH
     before_script:
-      - go version
+      - ./go-support/build/prebuild_go-support_in_docker.sh
     script:
-      - cd go-support/ && ./build/compile_protobufs.sh && go test -count=1 ./... && cd -
+      - cd go-support && ./build/run_go_test_in_docker.sh && cd -
 
   - name: docs tests
     before_script:
@@ -57,14 +50,7 @@ jobs:
     - sbt update
     - cd node-support && npm install && cd -
     - cd samples/js-shopping-cart && npm install && cd -
-    # these lines will be removed once revised task of
-    # buildGoTCKShoppingCart by @viktorklang will be merged (5b9df7c20b1da194d209f7a44b2bc29bdc601cd0)
-    # and the go build is done by the Go Docker container
-    - curl -L https://github.com/google/protobuf/releases/download/v3.9.1/protoc-3.9.1-linux-x86_64.zip -o /tmp/protoc-3.9.1-linux-x86_64.zip
-    - unzip /tmp/protoc-3.9.1-linux-x86_64.zip -d "$HOME"/protoc
-    - eval "$(gimme 1.13)" && go env
-    - go get -u github.com/golang/protobuf/protoc-gen-go
-    - pushd . && cd go-support && PATH=$HOME/protoc/bin:$PATH ./build/compile_protobufs.sh && cd shoppingcart/cmd/shoppingcart && CGO_ENABLED=0 go build -o tck_shoppingcart && popd
+    - sbt go-support/compile
     script:
     - sbt 'set concurrentRestrictions in Global += Tags.limitAll(1)' tck/it:test
 

build.sbt

@@ -674,9 +674,9 @@ lazy val `go-support` = (project in file("go-support"))
 
       val SuccessMessage = "go-support compiled successfully: " + os_arch + "\n"
 
-      (cmd !!) match {
-        case SuccessMessage =>
-          streams.value.log.success("go-support compilation succeeded")
+      (cmd !) match {
+        case 0 =>
+          streams.value.log.success(SuccessMessage)
           (compile in Compile).value // TODO should we produce our own compilation result instead perhaps?
         case err =>
           throw new IllegalStateException("go-support compilation failed: " + err)

go-support/build/build_tck_shopping_cart_in_docker.sh

@@ -1,8 +1,14 @@
 #!/usr/bin/env bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 SUFFIX=""
 if [ "$GOOS" == "windows" ]; then
   SUFFIX=".exe"
 fi
 
-cd shoppingcart/cmd/shoppingcart/ && CGO_ENABLED=0 go build -v -o "tck_shoppingcart${SUFFIX}" && echo "go-support compiled successfully: ${GOOS} on ${GOARCH}"
+./go-support/build/prebuild_go-support_in_docker.sh
+cd go-support/shoppingcart/cmd/shoppingcart/
+CGO_ENABLED=0 go build -v -o "tck_shoppingcart${SUFFIX}" && echo "go-support compiled successfully: ${GOOS} on ${GOARCH}"

go-support/build/compile_protobufs.sh

@@ -1,5 +1,9 @@
 #!/usr/bin/env bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 cp -a ../protocols protos
 
 protoc --go_out=plugins=grpc:. --proto_path=./protos/frontend/ --proto_path=./protos/protocol/ --proto_path=./protos/proxy/ --proto_path=./protos/example/ protos/protocol/cloudstate/entity.proto

go-support/build/prebuild_go-support_in_docker.sh

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+
+set -e
+
+apt-get update -y && apt-get install unzip -y
+curl -L https://github.com/google/protobuf/releases/download/v3.9.1/protoc-3.9.1-linux-x86_64.zip -o /tmp/protoc-3.9.1-linux-x86_64.zip
+unzip /tmp/protoc-3.9.1-linux-x86_64.zip -d "$HOME"/protoc
+# set GOOS and GOARCH to host values for this one line as protoc-gen-go has to be compiled.
+GOOS=linux GOARCH=amd64 go get -u github.com/golang/protobuf/protoc-gen-go
+
+cd go-support
+PATH=$HOME/protoc/bin:/$GOPATH/bin:$PATH ./build/compile_protobufs.sh

go-support/build/run_go_test_in_docker.sh

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+
+set -o nounset
+set -o errexit
+set -o pipefail
+
+docker run --rm -v "$PWD":/usr/src/myapp -w /usr/src/myapp golang:1.13 go test -count 1 -race ./...

go-support/build/run_tck_shopping_cart_build.ps1

@@ -1,4 +1,5 @@
 <#
 TODO: write the equivalence of the script build/run_tck_shopping_cart_build.sh
 #>
-Write-Host "someone with windows has to write this script"
+Write-Host "someone with windows has to write this script"
+Exit 1

go-support/build/run_tck_shopping_cart_build.sh

@@ -1,5 +1,8 @@
 #!/usr/bin/env bash
 
-cd go-support
+set -o nounset
+set -o errexit
+set -o pipefail
+
 docker run --rm -v "$PWD":/usr/src/myapp -w /usr/src/myapp -e GOOS=${1} -e GOARCH=${2} \
-golang:1.13 ./build/build_tck_shopping_cart_in_docker.sh
+golang:1.13 ./go-support/build/build_tck_shopping_cart_in_docker.sh

go-support/cloudstate/cloudstate.go

@@ -100,23 +100,24 @@ func (cs *CloudState) Register(ese *EventSourcedEntity, config DescriptorConfig)
 }
 
 // Run runs the CloudState instance.
-func (cs *CloudState) Run() {
+func (cs *CloudState) Run() error {
 	host, ok := os.LookupEnv("HOST")
 	if !ok {
-		log.Fatalf("unable to get environment variable \"HOST\"")
+		return fmt.Errorf("unable to get environment variable \"HOST\"")
 	}
 	port, ok := os.LookupEnv("PORT")
 	if !ok {
-		log.Fatalf("unable to get environment variable \"PORT\"")
+		return fmt.Errorf("unable to get environment variable \"PORT\"")
 	}
 	lis, err := net.Listen("tcp", fmt.Sprintf("%s:%s", host, port))
 	if err != nil {
-		log.Fatalf("failed to listen: %v\n", err)
+		return fmt.Errorf("failed to listen: %v\n", err)
 	}
 	log.Printf("starting grpcServer at: %s:%s", host, port)
 	if e := cs.server.Serve(lis); e != nil {
-		log.Fatalf("failed to grpcServer.Serve for: %v", lis)
+		return fmt.Errorf("failed to grpcServer.Serve for: %v", lis)
 	}
+	return nil
 }
 
 // EntityDiscoveryResponder implements the CloudState discovery protocol.
@@ -240,7 +241,10 @@ func (r *EntityDiscoveryResponder) registerFileDescriptorProto(filename string)
 }
 
 func (r *EntityDiscoveryResponder) registerFileDescriptor(msg descriptor.Message) error {
-	fd, _ := descriptor.ForMessage(msg) // this can panic, so we do here
+	fd, _ := descriptor.ForMessage(msg) // this can panic
+	if r := recover(); r != nil {
+		return fmt.Errorf("descriptor.ForMessage panicked (%v) for: %+v", r, msg)
+	}
 	r.fileDescriptorSet.File = append(r.fileDescriptorSet.File, fd)
 	return nil
 }