Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Moves the test utils generation script to this repo #77

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Nov 28, 2024

Description of changes:

Centralizes the logic repeated in these four files:

  1. Components: test-utils.js
  2. Code view: test-utils.js
  3. Chat components: test-utils.js
  4. Board components: test-utils.js

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue #, if available:

Will be followed by PRs:

Related API Proposal: Test utils component finder generator

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 22.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (75b167d) to head (8f3e6af).

Files with missing lines Patch % Lines
src/converter/generate-test-utils.ts 0.00% 22 Missing and 1 partial ⚠️
src/converter/setup-tests.ts 0.00% 9 Missing and 2 partials ⚠️
src/converter/utils.ts 62.50% 3 Missing ⚠️
src/converter/generate-component-finders.ts 75.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (75b167d) and HEAD (8f3e6af). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (75b167d) HEAD (8f3e6af)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #77       +/-   ##
===========================================
- Coverage   95.75%   84.68%   -11.08%     
===========================================
  Files           6       10        +4     
  Lines         283      333       +50     
  Branches       65       69        +4     
===========================================
+ Hits          271      282       +11     
- Misses         12       48       +36     
- Partials        0        3        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon force-pushed the chore/adds-test-utils-build-scripts branch from 98b36f6 to 8f3e6af Compare December 2, 2024 14:28
*/
export function getComponentMetadata(componentName: string) {
return ${buildComponentsMetadataMap(components)}[componentName];
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above function is the only one that is new. Everything else is just transferred from other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant