Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Property filter duplicates property name in suggestion when the label is empty #530

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

connorlanigan
Copy link
Member

Description

When the label of a suggested value in the property filter is empty, it uses the value instead. However, the value contains the property name, so the property name is duplicated. With this change, an empty value of an option is correctly displayed as empty.

Related links, issue #, if available: AWSUI-19878

How has this been tested?

Manual testing in a dev page

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 92.59% // Head: 92.59% // No change to project coverage 👍

Coverage data is based on head (2085af1) compared to base (4bb4f3a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         568      568           
  Lines       16163    16163           
  Branches     4425     4425           
=======================================
  Hits        14966    14966           
  Misses       1116     1116           
  Partials       81       81           
Impacted Files Coverage Δ
src/internal/components/option/index.tsx 96.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@connorlanigan connorlanigan marked this pull request as ready for review November 25, 2022 15:37
@connorlanigan connorlanigan requested a review from a team as a code owner November 25, 2022 15:37
@connorlanigan connorlanigan requested review from YueyingLu and removed request for a team November 25, 2022 15:37
@connorlanigan connorlanigan merged commit d815129 into main Nov 29, 2022
@connorlanigan connorlanigan deleted the fix/property-filter-duplicated-label branch November 29, 2022 10:31
katiegeorge pushed a commit that referenced this pull request Nov 30, 2022
taheramr pushed a commit that referenced this pull request Dec 1, 2022
@timogasda
Copy link
Member

This fixes #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants