fix: Remove table round corner under header #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.59% // Head: 92.59% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 568 568
Lines 16163 16163
Branches 4425 4425
=======================================
Hits 14966 14966
Misses 1116 1116
Partials 81 81 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abdhalees
reviewed
Nov 28, 2022
abdhalees
reviewed
Nov 28, 2022
| @@ -79,6 +77,10 @@ | |||
| &.has-footer { | |||
| padding-bottom: 0px; | |||
| } | |||
| &:not(.has-header) { | |||
There was a problem hiding this comment.
the issue says it only happens in embedded tables, why do we need to remove the border from every table?
There was a problem hiding this comment.
It actually happens to not only embedded. But in general, when there is already a header. For example container:
YueyingLu
changed the title
abdhalees
approved these changes
Nov 28, 2022
katiegeorge
pushed a commit
that referenced
this pull request
Nov 30, 2022
taheramr
pushed a commit
that referenced
this pull request
Dec 1, 2022
|
This fixes #503. |
2 tasks
rubencarvalho
pushed a commit
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Table rounded corner causes gap between header. The fix is to remove the border-radius when header exists.
Related links, issue AWSUI-19854
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.