Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the Modal component to allow modalRoot to also be the target… #444

Closed
wants to merge 1 commit into from

Conversation

AJStacy
Copy link

@AJStacy AJStacy commented Nov 3, 2022

… of scroll locking styles. I created a alt-modal-root demo page as well to see the changes in action.

Description

[Include a summary of the changes and the related issue.]

[Also include relevant motivation and context.]

How has this been tested?

[How did you test to verify your changes?]

[How can reviewers test these changes efficiently?]

[Check for unexpected visual regressions, see CONTRIBUTING.md for details.]

Documentation changes

[Do the changes include any API documentation changes?]

  • Yes, this change contains documentation changes.
  • No.

Related Links

[Attach any related links/pull request for this change]

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

… of scroll locking styles. I created a alt-modal-root demo page as well to see the changes in action.
@just-boris
Copy link
Member

just-boris commented Nov 14, 2022

As discussed in the linked issue, #423 (comment), this change is not needed.

Feel free to continue the discussion in the issue thread

@just-boris just-boris closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants