-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tab header "actions" #3293
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
========================================
Coverage 96.42% 96.42%
========================================
Files 791 791
Lines 22580 22583 +3
Branches 7794 7388 -406
========================================
+ Hits 21772 21775 +3
Misses 801 801
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
but this metrics prop could become confusing
Line 52 in 50a91a6
hasActions: tabs.some(tab => !!tab.action), |
I would initially think it refers to the header actions not a tab action, changing it would be a breaking change though, so adding a new metric prop hasHeaderActions
could remove the confusion + it's useful anyway.
6337f77
to
1db7bd2
Compare
Note: codecov failing due to unrelated lines [indent change only]. The related functionality is heavily integ-tested as it's challenging to test in unit testing environment. |
Description
Add a slot for "actions", placed within the tabs header
Related links, issue #, if available: 4aAdA16jV0dV
How has this been tested?
New unit tests & permutations
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.