Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update segmented control visual design #3289

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

at-susie
Copy link
Member

Description

Improve the visual design for segmented control to mitigate the bulkiness.

image

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (0906374) to head (b1be279).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3289   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         791      791           
  Lines       22605    22607    +2     
  Branches     7745     7806   +61     
=======================================
+ Hits        21797    21799    +2     
  Misses        754      754           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-susie at-susie marked this pull request as ready for review February 12, 2025 17:25
@at-susie at-susie requested a review from a team as a code owner February 12, 2025 17:25
@at-susie at-susie requested review from gethinwebster and removed request for a team February 12, 2025 17:25
Copy link
Member

@gethinwebster gethinwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall ok, but the CSS needs to be made a bit more token-/variable-based

src/segmented-control/segment.scss Outdated Show resolved Hide resolved
src/segmented-control/styles.scss Outdated Show resolved Hide resolved
src/segmented-control/styles.scss Outdated Show resolved Hide resolved
src/segmented-control/styles.scss Outdated Show resolved Hide resolved
src/segmented-control/segment.scss Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants