Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert changes to analytics metadata interfaces #3279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fralongo
Copy link
Member

Description

Reverting cleanup of analytics interfaces 30c890d4cdaf6e9e175c08370563d7edabc7c0a6Needed because the analytics team needs these types to process the data

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates. N/A
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md. Yes
  • Changes do not include unsupported browser features, see CONTRIBUTING.md. N/A
  • Changes were manually tested for accessibility, see accessibility guidelines. N/A

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fralongo fralongo requested a review from a team as a code owner February 11, 2025 19:37
@fralongo fralongo requested review from connorlanigan and removed request for a team February 11, 2025 19:37
@just-boris
Copy link
Member

Can we talk more what is happening in this PR?

This code is statically disconnected from the rest of codebase. Either someone violates our public API (which they shouldn't) or something does not work as they expect.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (7c8f26d) to head (a6a5732).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
- Coverage   96.42%   96.41%   -0.01%     
==========================================
  Files         791      791              
  Lines       22574    22563      -11     
  Branches     7735     7786      +51     
==========================================
- Hits        21766    21755      -11     
- Misses        754      801      +47     
+ Partials       54        7      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fralongo
Copy link
Member Author

Can we talk more what is happening in this PR?

This code is statically disconnected from the rest of codebase. Either someone violates our public API (which they shouldn't) or something does not work as they expect.

Exposing these interfaces for the analytics team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants