Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow manual tab activation #3271

Merged
merged 8 commits into from
Feb 17, 2025
Merged

feat: Allow manual tab activation #3271

merged 8 commits into from
Feb 17, 2025

Conversation

gethinwebster
Copy link
Member

Description

Add keyboardActivationMode to tabs component, to allow for manual activation if desired.

Related links, issue #, if available: n/a

How has this been tested?

New tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (66e818c) to head (3c67cb5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3271   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         791      791           
  Lines       22585    22590    +5     
  Branches     7735     7800   +65     
=======================================
+ Hits        21777    21782    +5     
  Misses        754      754           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster marked this pull request as ready for review February 11, 2025 13:04
@gethinwebster gethinwebster requested a review from a team as a code owner February 11, 2025 13:04
@gethinwebster gethinwebster requested review from pan-kot and removed request for a team February 11, 2025 13:04
Co-authored-by: Andrei Zhaleznichenka <[email protected]>
Co-authored-by: Andrei Zhaleznichenka <[email protected]>
pan-kot
pan-kot previously approved these changes Feb 12, 2025
pan-kot
pan-kot previously approved these changes Feb 13, 2025
@gethinwebster gethinwebster added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 6b9200b Feb 17, 2025
38 checks passed
@gethinwebster gethinwebster deleted the tabs-activation-mode branch February 17, 2025 19:01
georgylobko pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants