-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow manual tab activation #3271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3271 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 791 791
Lines 22585 22590 +5
Branches 7735 7800 +65
=======================================
+ Hits 21777 21782 +5
Misses 754 754
Partials 54 54 ☔ View full report in Codecov by Sentry. |
f59e847
to
49752c1
Compare
pan-kot
reviewed
Feb 12, 2025
Co-authored-by: Andrei Zhaleznichenka <[email protected]>
pan-kot
reviewed
Feb 12, 2025
Co-authored-by: Andrei Zhaleznichenka <[email protected]>
pan-kot
reviewed
Feb 12, 2025
pan-kot
previously approved these changes
Feb 12, 2025
pan-kot
previously approved these changes
Feb 13, 2025
pan-kot
approved these changes
Feb 17, 2025
georgylobko
pushed a commit
that referenced
this pull request
Feb 18, 2025
Co-authored-by: Andrei Zhaleznichenka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
keyboardActivationMode
to tabs component, to allow for manual activation if desired.Related links, issue #, if available: n/a
How has this been tested?
New tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.