chore: Add proper textual name, role and state to breadcrumb last item #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
========================================
Coverage 96.44% 96.44%
========================================
Files 791 791
Lines 22568 22572 +4
Branches 7385 7731 +346
========================================
+ Hits 21765 21769 +4
+ Misses 796 750 -46
- Partials 7 53 +46 ☔ View full report in Codecov by Sentry. |
avinashbot
reviewed
Feb 6, 2025
src/breadcrumb-group/item/item.tsx
Outdated
| @@ -70,7 +70,7 @@ type ItemProps = React.HTMLAttributes<HTMLElement> & { | |||
| const Item = React.forwardRef<HTMLElement, ItemProps>( | |||
| ({ anchorAttributes, children, isLast, ...itemAttributes }, ref) => | |||
| isLast ? ( | |||
| <span ref={ref} className={styles.anchor} {...itemAttributes}> | |||
| <span role="link" aria-disabled={true} ref={ref} className={styles.anchor} {...itemAttributes}> | |||
There was a problem hiding this comment.
Hmm, I wonder if we should only do this if the last item is focusable in the first place rather than applying it to every last item? Because the problem is only there if we make the element focusable, which is only the case if it's truncated.
I don't have a good answer; something to check with our accessibility specialists later today?
There was a problem hiding this comment.
Had a chat, here's the outcome:
- It would nice for all terminal breadcrumb group items (not just truncated ones) to be
role="link",aria-disabled="true", and also tabbable. This makes for a consistent navigation experience through the entire breadcrumb list. - And if we're going to do that, we should also add
aria-current="page"to the final breadcrumb item.
taheramr
force-pushed
the
chore/breadcrumb-last-item-a11y
branch
from
6e75920 to
9342646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding proper textual name, role and state for the last item in the breadcrumb group.
Why?
At narrow viewports, the truncated final breadcrumb item is focusable, but it has no role and disabled state. (Note: The breadcrumb items are not long enough to trigger truncation in the demo. However, truncation occurs frequently in practice.)
Related links, issue #, if available: n/a
AWSUI-60244
How has this been tested?
Using inspector and inspecting the A11y tree before and after
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.