-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allows table cells be expandable and editable at the same time #3205
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
==========================================
+ Coverage 96.42% 96.45% +0.03%
==========================================
Files 787 791 +4
Lines 22190 22310 +120
Branches 7206 7255 +49
==========================================
+ Hits 21396 21520 +124
+ Misses 787 783 -4
Partials 7 7 ☔ View full report in Codecov by Sentry. |
0595994
to
a93a8b2
Compare
a93a8b2
to
985037b
Compare
985037b
to
d7ea97d
Compare
b58991d
to
408ab12
Compare
408ab12
to
57c7b25
Compare
219b1ce
to
88a8e82
Compare
88a8e82
to
270bd64
Compare
270bd64
to
b41676b
Compare
@gethinwebster, I added a small refactoring on top, removing the onMouseEnter/onMouseExit handlers from the cell. Apologies for not creating a separate commit for that! The reason the handlers are removed is the following:
|
Description
The PR makes it possible to have cell editing in the first column of tables with expandable rows.
Rel: [tNAkA40KWyvj], AWSUI-43194.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.