-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Inline multiselect tokens #3185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3185 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 787 787
Lines 22191 22191
Branches 7555 7614 +59
=======================================
Hits 21398 21398
- Misses 741 786 +45
+ Partials 52 7 -45 ☔ View full report in Codecov by Sentry. |
katiegeorge
changed the title
Kg/inline multiselect tokens
feat: Inline multiselect tokens
Jan 13, 2025
katiegeorge
force-pushed
the
kg/inline-multiselect-tokens
branch
from
January 17, 2025 19:35
ba1c57a
to
02428ba
Compare
Al-Dani
previously approved these changes
Jan 20, 2025
katiegeorge
force-pushed
the
kg/inline-multiselect-tokens
branch
from
January 21, 2025 19:35
02428ba
to
1f20369
Compare
katiegeorge
force-pushed
the
kg/inline-multiselect-tokens
branch
from
January 22, 2025 20:00
9ad9f39
to
0fa964b
Compare
avinashbot
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves inline tokens in multiselect out of beta and into a public feature.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.