chore: Adds feature metrics for collection prefs and button group

[pan-kot]

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

• Changes include appropriate documentation updates.
• Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
• Changes do not include unsupported browser features, see CONTRIBUTING.md.
• Changes were manually tested for accessibility, see accessibility guidelines.

Security

• If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

• Changes are covered with new/existing unit tests?
• Changes are covered with new/existing integration tests?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (f9aeff8) to head (eae6af7).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3180   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         784      784           
  Lines       22168    22178   +10     
  Branches     7206     7207    +1     
=======================================
+ Hits        21373    21383   +10     
  Misses        788      788           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[timogasda]

should this be false instead? Not sure how the metrics handle undefined values here

[just-boris]

Metrics use JSON.stringify. When you serialise undefined, it disappears completely, same as this key did not exist before.

Explicit casting is recommended

[pan-kot]

Yeah, I was thinking about that too, but decided not touch it just yet. I think it would be nice to align within the team if we want to cast or not and how do we want to treat properties that have defaults: should we pass the default value or the missing one, as it directly affects the actual metrics we gather.

[just-boris]

In all other cases, we track resolved values after defaulting.

For dropdownExpandToViewport there is an implicit default false which we should be tracking.

[pan-kot]

After the team discussion we settled on passing the default property values to metrics. I added a new commit that implements that for dropdownExpandToViewport.

[just-boris]

The comment thread is about existing behavior, not new.

Approving, but fixing that reporting would be nice follow up