fix: Remove background color from borderless table header #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3162 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 784 784
Lines 22143 22143
Branches 7604 7536 -68
=======================================
Hits 21348 21348
Misses 743 743
Partials 52 52 ☔ View full report in Codecov by Sentry. |
orangevolon
reviewed
Jan 14, 2025
| @@ -75,6 +75,9 @@ $cell-horizontal-padding: awsui.$space-scaled-l; | |||
| &-variant-full-page.header-cell-hidden { | |||
| border-block-end-color: transparent; | |||
| } | |||
| &-variant-borderless { | |||
| background: none; | |||
There was a problem hiding this comment.
Just wondering why we used background: none here and the background-color: transparent above. Are we expecting any "non-color" backgrounds?
There was a problem hiding this comment.
The only reason is that above the background color is set using background-color and similarly here using background so setting background-color where background is used doesn't remove the color.
orangevolon
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed background color from borderless table header
Related links, issue #, if available: AWSUI-60188
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.