Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates table cell permutations page #3071

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Nov 28, 2024

Description

Adding more cell content variations to support this refactoring: #3061

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (49a178d) to head (534cc93).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3071      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         780      779       -1     
  Lines       21928    21914      -14     
  Branches     7503     7502       -1     
==========================================
- Hits        21127    21113      -14     
  Misses        794      794              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot force-pushed the editable-cells-wrapper-baseline branch from 8cd4aa3 to 534cc93 Compare November 29, 2024 08:48
@pan-kot pan-kot marked this pull request as ready for review November 29, 2024 09:39
@pan-kot pan-kot requested a review from a team as a code owner November 29, 2024 09:39
@pan-kot pan-kot requested review from taheramr and removed request for a team November 29, 2024 09:39
@pan-kot pan-kot enabled auto-merge December 3, 2024 16:49
@pan-kot pan-kot added this pull request to the merge queue Dec 4, 2024
@just-boris just-boris removed this pull request from the merge queue due to a manual request Dec 4, 2024
@pan-kot pan-kot added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 606beea Dec 6, 2024
39 checks passed
@pan-kot pan-kot deleted the editable-cells-wrapper-baseline branch December 6, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants