Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Componentizes table cell types and adds permutations #3041

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

just-boris
Copy link
Member

Reverts #3017 because there are some visual regressions to investigate

@just-boris just-boris marked this pull request as ready for review November 20, 2024 18:38
@just-boris just-boris requested a review from a team as a code owner November 20, 2024 18:38
@just-boris just-boris requested review from connorlanigan and removed request for a team November 20, 2024 18:38
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (035ae6b) to head (dcdaefa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/table/internal.tsx 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3041      +/-   ##
==========================================
- Coverage   96.33%   96.32%   -0.02%     
==========================================
  Files         779      777       -2     
  Lines       21900    21893       -7     
  Branches     7503     7093     -410     
==========================================
- Hits        21097    21088       -9     
- Misses        751      797      +46     
+ Partials       52        8      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@just-boris just-boris added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 6d25f88 Nov 20, 2024
37 of 38 checks passed
@just-boris just-boris deleted the revert-3017-refactor-table-cell-types branch November 20, 2024 19:06
pan-kot added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants