chore: Tolerate other analytics events in flashbar analytics tests #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Sep 10, 2024
| @@ -20,22 +19,14 @@ let useVisualRefresh = false; | |||
| jest.mock('../../../lib/components/internal/hooks/use-visual-mode', () => { | |||
| const originalVisualModeModule = jest.requireActual('../../../lib/components/internal/hooks/use-visual-mode'); | |||
| return { | |||
| __esModule: true, | |||
| @@ -450,155 +441,3 @@ describe('Flashbar component', () => { | |||
| testFlashDismissal({ stackItems: false }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Analytics', () => { | |||
There was a problem hiding this comment.
This is a separate top-level describe block, which naturally suggests it should be a separate test file in the first place
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
========================================
Coverage 95.85% 95.85%
========================================
Files 744 744
Lines 20581 20581
Branches 6644 7015 +371
========================================
Hits 19727 19727
Misses 846 846
Partials 8 8 ☔ View full report in Codecov by Sentry. |
georgylobko
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.