Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: itemsControl property of Side Navigation #2673

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

Manzurka
Copy link
Contributor

@Manzurka Manzurka commented Sep 5, 2024

Description

Items Control property allows customers to define the component of their chose to be added to a slot below the header and above the items of Side Navigation Panel. For example, customers can pass Select or Multi-select components with custom attribute values (ex. options, selectedOption, triggerVariant, label, loadingText). Use case: This allows customers to define a callback function onChange event of the component, for example, to allow users filter out navigation menu items.

Related links
AWSUI-54774
API Proposal ID bG8cAsCSosVm

How has this been tested?

Unit tests, snapshot test, integ test have been added.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests? yes
  • Changes are covered with new/existing integration tests? yes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Manzurka Manzurka requested a review from a team as a code owner September 5, 2024 21:39
@Manzurka Manzurka requested review from pan-kot and removed request for a team September 5, 2024 21:39
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (e55cdca) to head (b7d5556).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
+ Coverage   95.85%   95.93%   +0.08%     
==========================================
  Files         744      746       +2     
  Lines       20581    20679      +98     
  Branches     7024     7043      +19     
==========================================
+ Hits        19727    19839     +112     
- Misses        798      832      +34     
+ Partials       56        8      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pan-kot
pan-kot previously approved these changes Sep 6, 2024
Copy link
Member

@pan-kot pan-kot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Manzurka Manzurka changed the title feat: itemsHeader property of Side Navigation feat: itemsControl property of Side Navigation Sep 10, 2024
@Manzurka
Copy link
Contributor Author

Screenshot 2024-09-11 at 11 36 20 AM

@pan-kot pan-kot added this pull request to the merge queue Sep 13, 2024
Merged via the queue into cloudscape-design:main with commit 3b871f2 Sep 13, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants