feat: Add analytics metadata to Autosuggest component #2667
Conversation
| export interface GeneratedAnalyticsMetadataAutosuggestClearInput { | ||
| action: 'clearInput'; | ||
| detail: { | ||
| label: string; | ||
| }; | ||
| } |
There was a problem hiding this comment.
This interface isn't being used?
There was a problem hiding this comment.
It is not, I am still adding all of them in the component analytics interface, so that I will be able to automatically generate documentation in the future. I did push an improvement to at least use it in the input component, and import it from there.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
=======================================
Coverage 95.79% 95.80%
=======================================
Files 744 744
Lines 20563 20573 +10
Branches 6636 6643 +7
=======================================
+ Hits 19699 19709 +10
Misses 856 856
Partials 8 8 ☔ View full report in Codecov by Sentry. |
| name: 'awsui.Autosuggest', | ||
| label: 'input', | ||
| properties: { | ||
| disabled: `${!!props.disabled}`, |
There was a problem hiding this comment.
Should this also include readonly?
There was a problem hiding this comment.
I can include it at a later stage if needed
Description
Similar to dde2462
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.