Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add alert/flash content replacement runtime API #2647

Merged
merged 36 commits into from
Sep 13, 2024

Conversation

gethinwebster
Copy link
Member

Description

Add runtime API for alert & flash content replacement

Related links, issue #, if available: ZnrFADMnL1Vy

How has this been tested?

New unit tests, updated screenshot pages

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (2e32ba3) to head (538df4b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
+ Coverage   95.94%   95.95%   +0.01%     
==========================================
  Files         746      748       +2     
  Lines       20676    20785     +109     
  Branches     7042     6697     -345     
==========================================
+ Hits        19837    19945     +108     
- Misses        831      832       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-content-replacement branch from 5c61041 to aa6ae9e Compare September 2, 2024 16:07
@gethinwebster gethinwebster marked this pull request as ready for review September 3, 2024 09:27
@gethinwebster gethinwebster requested a review from a team as a code owner September 3, 2024 09:27
@gethinwebster gethinwebster requested review from johannes-weber and removed request for a team September 3, 2024 09:27
@gethinwebster gethinwebster marked this pull request as draft September 3, 2024 09:28
@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-content-replacement branch 2 times, most recently from 648a197 to 58291d6 Compare September 4, 2024 09:38
@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-content-replacement branch from 58291d6 to fa074bb Compare September 4, 2024 16:13
@gethinwebster gethinwebster marked this pull request as ready for review September 5, 2024 07:22
pages/alert/runtime-content.page.tsx Show resolved Hide resolved
pages/alert/runtime-content.page.tsx Outdated Show resolved Hide resolved
pages/alert/runtime-content.page.tsx Outdated Show resolved Hide resolved
pages/alert/runtime-content.page.tsx Outdated Show resolved Hide resolved
pages/alert/runtime-content.page.tsx Outdated Show resolved Hide resolved
src/alert/__tests__/runtime-content.test.tsx Show resolved Hide resolved
src/alert/__tests__/runtime-content.test.tsx Outdated Show resolved Hide resolved
src/alert/__tests__/runtime-content.test.tsx Outdated Show resolved Hide resolved
src/alert/__tests__/runtime-content.test.tsx Show resolved Hide resolved
src/flashbar/__tests__/runtime-content.test.tsx Outdated Show resolved Hide resolved
pages/alert/runtime-content.page.tsx Outdated Show resolved Hide resolved
src/alert/__tests__/alert.test.tsx Outdated Show resolved Hide resolved
src/alert/__tests__/alert.test.tsx Outdated Show resolved Hide resolved
src/alert/__tests__/runtime-content.test.tsx Outdated Show resolved Hide resolved
src/alert/__tests__/runtime-content.test.tsx Outdated Show resolved Hide resolved
src/internal/plugins/helpers/use-discovered-content.tsx Outdated Show resolved Hide resolved
src/internal/plugins/controllers/alert-flash-content.ts Outdated Show resolved Hide resolved
src/internal/plugins/controllers/alert-flash-content.ts Outdated Show resolved Hide resolved
src/internal/plugins/helpers/use-discovered-content.tsx Outdated Show resolved Hide resolved
src/internal/plugins/controllers/alert-flash-content.ts Outdated Show resolved Hide resolved
@pan-kot pan-kot dismissed stale reviews from johannes-weber and just-boris via 538df4b September 12, 2024 18:16
@pan-kot pan-kot force-pushed the dev-v3-gethinw-alert-content-replacement branch from 14778f6 to 538df4b Compare September 12, 2024 18:16
@pan-kot
Copy link
Member

pan-kot commented Sep 12, 2024

@just-boris, @gethinwebster, I rebased with main as there was a small conflicts with flashbar analytics changes. Please re-approve. Thanks!

@pan-kot pan-kot added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit a039398 Sep 13, 2024
42 checks passed
@pan-kot pan-kot deleted the dev-v3-gethinw-alert-content-replacement branch September 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants