-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add alert/flash content replacement runtime API #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
==========================================
+ Coverage 95.94% 95.95% +0.01%
==========================================
Files 746 748 +2
Lines 20676 20785 +109
Branches 7042 6697 -345
==========================================
+ Hits 19837 19945 +108
- Misses 831 832 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. |
gethinwebster
force-pushed
the
dev-v3-gethinw-alert-content-replacement
branch
from
September 2, 2024 16:07
5c61041
to
aa6ae9e
Compare
gethinwebster
requested review from
johannes-weber
and removed request for
a team
September 3, 2024 09:27
gethinwebster
force-pushed
the
dev-v3-gethinw-alert-content-replacement
branch
2 times, most recently
from
September 4, 2024 09:38
648a197
to
58291d6
Compare
gethinwebster
force-pushed
the
dev-v3-gethinw-alert-content-replacement
branch
from
September 4, 2024 16:13
58291d6
to
fa074bb
Compare
pan-kot
reviewed
Sep 5, 2024
just-boris
reviewed
Sep 6, 2024
just-boris
reviewed
Sep 6, 2024
pan-kot
dismissed stale reviews from johannes-weber and just-boris
via
September 12, 2024 18:16
538df4b
pan-kot
force-pushed
the
dev-v3-gethinw-alert-content-replacement
branch
from
September 12, 2024 18:16
14778f6
to
538df4b
Compare
@just-boris, @gethinwebster, I rebased with main as there was a small conflicts with flashbar analytics changes. Please re-approve. Thanks! |
pan-kot
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add runtime API for alert & flash content replacement
Related links, issue #, if available: ZnrFADMnL1Vy
How has this been tested?
New unit tests, updated screenshot pages
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.