-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Introduce token focus controller helper #2633
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2633 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 743 743
Lines 20409 20469 +60
Branches 6942 6965 +23
=======================================
+ Hits 19553 19611 +58
- Misses 848 850 +2
Partials 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The useListFocusController is a nice solution to the problem.
Description
Standardise focus handling between property filter tokens, nested tokens, editor tokens, file upload, and token editor.
This also fixes a bug caused but next filter index not being cleaned up. As result, the token transition did not always happen or instead of focusing on the adjacent token the focus moved to the input, see recording:
Screen.Recording.2024-08-30.at.10.46.26.mov
This is a preparation for property filter with token groups feature: #2627
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.