feat: App layout global drawers #2596
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2596 +/- ##
==========================================
+ Coverage 96.10% 96.15% +0.04%
==========================================
Files 754 756 +2
Lines 21027 21279 +252
Branches 7115 7220 +105
==========================================
+ Hits 20209 20460 +251
- Misses 764 765 +1
Partials 54 54 ☔ View full report in Codecov by Sentry. |
…t on the screen due to a limited width
…l-drawers # Conflicts: # src/app-layout/__integ__/runtime-drawers.test.ts
src/app-layout/classic.tsx
Outdated
| @@ -592,7 +592,7 @@ const ClassicAppLayout = React.forwardRef( | |||
| bottomOffset={placement.insetBlockEnd} | |||
| topOffset={placement.insetBlockStart} | |||
| isMobile={isMobile} | |||
| drawers={drawers} | |||
| drawers={drawers.filter(item => !!item.trigger)} | |||
There was a problem hiding this comment.
There is still one here: #2596 (comment)
| }, [disableRuntimeDrawers, onGlobalDrawersChangeStable, onLocalDrawerChangeStable]); | ||
|
|
||
| useEffect(() => { | ||
| const unsubscribe = awsuiPluginsInternal.appLayout.onDrawerOpened(drawerId => { |
There was a problem hiding this comment.
There are seem to be some issues with this effect. Try adding console.log inside onDrawerOpened and check if it is rendered too often (for example, on every navigation open/close)
There was a problem hiding this comment.
Just tried. Works fine
There was a problem hiding this comment.
I also tried. Does not work fine :(
There was a problem hiding this comment.
Reproduced offline. Declaring this a Follow up improvement
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.