chore: Use new property filter token editor #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-kot
requested review from
avinashbot and
georgylobko
and removed request for
a team
pan-kot
commented
Aug 13, 2024
| @@ -280,3 +292,308 @@ describe.each([false, true])('token editor, expandToViewport=%s', expandToViewpo | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| const externalProperty = { | |||
There was a problem hiding this comment.
All tests below were copied from the token-editor-grouped test file, no changes to the tests was made
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2564 +/- ##
========================================
Coverage 95.78% 95.78%
========================================
Files 741 741
Lines 20282 20270 -12
Branches 6519 6840 +321
========================================
- Hits 19427 19416 -11
+ Misses 847 798 -49
- Partials 8 56 +48 ☔ View full report in Codecov by Sentry. |
gethinwebster
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the new token editor in property filter by default with supportsGroups=false.
A follow-up for: #2490
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.