Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Property filter groups phase 1 #2454

Closed
wants to merge 22 commits into from
Closed

feat: Property filter groups phase 1 #2454

wants to merge 22 commits into from

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Jul 10, 2024

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

scripts/install-peer-dependency.js Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 85.09615% with 31 lines in your changes missing coverage. Please review.

Project coverage is 95.57%. Comparing base (a8fdb97) to head (98c6755).
Report is 7 commits behind head on main.

Files Patch % Lines
src/property-filter/token-editor.tsx 82.27% 14 Missing ⚠️
src/property-filter/controller.ts 73.17% 11 Missing ⚠️
src/property-filter/index.tsx 86.95% 3 Missing ⚠️
src/property-filter/token.tsx 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   95.65%   95.57%   -0.08%     
==========================================
  Files         722      725       +3     
  Lines       19333    19701     +368     
  Branches     6160     6295     +135     
==========================================
+ Hits        18493    18830     +337     
- Misses        832      863      +31     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot
Copy link
Member Author

pan-kot commented Aug 28, 2024

Closed in favour of #2626

@pan-kot pan-kot closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant