Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Partially rounded corners for stacked bar charts #2190

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Apr 23, 2024

Description

Reverting PR #2171 due to unexpected performance impact.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner April 23, 2024 11:02
@pan-kot pan-kot requested review from just-boris and removed request for a team April 23, 2024 11:02
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.34%. Comparing base (34b4ff4) to head (5b4765c).

Files Patch % Lines
src/mixed-line-bar-chart/utils.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2190      +/-   ##
==========================================
- Coverage   95.35%   95.34%   -0.02%     
==========================================
  Files         687      687              
  Lines       18407    18382      -25     
  Branches     6161     6150      -11     
==========================================
- Hits        17552    17526      -26     
- Misses        801      802       +1     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot merged commit ffc5b2a into main Apr 23, 2024
35 checks passed
@pan-kot pan-kot deleted the revert-stacked-bar-chart-radius branch April 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants