-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding aria label to property filter token operator button #491
Conversation
merging latest
src/select/internal.tsx
Outdated
@@ -155,6 +155,7 @@ const InternalSelect = React.forwardRef( | |||
{...formFieldContext} | |||
controlId={controlId} | |||
ariaLabelledby={joinStrings(formFieldContext.ariaLabelledby, selectAriaLabelId)} | |||
ariaLabel={ariaLabel} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add ariaLabel in Select because Select does it itself already. You can remove this line and the change in select/parts.
components/src/select/internal.tsx
Line 233 in ab8601c
<ScreenreaderOnly id={selectAriaLabelId}>{ariaLabel}</ScreenreaderOnly> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YueyingLu this is fixed now.
src/property-filter/interfaces.ts
Outdated
@@ -215,6 +215,7 @@ export namespace PropertyFilterProps { | |||
tokenLimitShowMore?: string; | |||
tokenLimitShowFewer?: string; | |||
clearFiltersText: string; | |||
operatorAriaLabel?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operatorAriaLabel
to me is not very clear, which operator it refers to as there are many operators for different uses in PropertyFilter. I suggest more specific naming like tokenOperatorAriaLabel
. @avinashbot wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it made sense to me, so went ahead and fixed, @avinashbot, let me know if you see any issues.
Hi @varghvi |
Codecov ReportBase: 92.38% // Head: 92.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 569 569
Lines 16218 16219 +1
Branches 4433 4433
=======================================
+ Hits 14983 14984 +1
Misses 1151 1151
Partials 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Adding operatorAriaLabel property to I18nStrings to set aria-label to filter token operator.
AWSUI-19118
[Include a summary of the changes and the related issue.]
[Also include relevant motivation and context.]
How has this been tested?
[How did you test to verify your changes?]
[How can reviewers test these changes efficiently?]
[Check for unexpected visual regressions, see
CONTRIBUTING.md
for details.]Documentation changes
[Do the changes include any API documentation changes?]
Related Links
[Attach any related links/pull request for this change]
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.