Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Reintroduces table cell types permutations and refactoring #3043

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Nov 21, 2024

This reverts commit 6d25f88 to re-introduce #3017

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner November 21, 2024 06:59
@pan-kot pan-kot requested review from dpitcock and cansuaa and removed request for a team and dpitcock November 21, 2024 06:59
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (22af933) to head (5ea240f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3043      +/-   ##
==========================================
+ Coverage   96.33%   96.34%   +0.01%     
==========================================
  Files         778      780       +2     
  Lines       21913    21920       +7     
  Branches     7502     7500       -2     
==========================================
+ Hits        21109    21118       +9     
+ Misses        751      750       -1     
+ Partials       53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pan-kot pan-kot added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 6663503 Nov 21, 2024
38 checks passed
@pan-kot pan-kot deleted the revert-revert-table-cell-types branch November 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants