Skip to content

Commit

Permalink
fix: Minor review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
georgylobko committed Sep 10, 2024
1 parent 0dbe0d7 commit af49dab
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions src/app-layout/__tests__/runtime-drawers-layout.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// SPDX-License-Identifier: Apache-2.0
/* eslint simple-import-sort/imports: 0 */
import React from 'react';
import { act, render } from '@testing-library/react';
import { act, render, waitFor } from '@testing-library/react';
import { describeEachAppLayout, getGlobalDrawersTestUtils, testDrawer } from './utils';
import AppLayout from '../../../lib/components/app-layout';
import { awsuiPlugins, awsuiPluginsInternal } from '../../../lib/components/internal/plugins/api';
Expand Down Expand Up @@ -107,9 +107,9 @@ describe('toolbar mode only features', () => {

wrapper.findDrawerTriggerById('local-drawer')!.click();

await delay();

expect(globalDrawersWrapper.findActiveDrawers()!.length).toBe(2);
await waitFor(() => {
expect(globalDrawersWrapper.findActiveDrawers()!.length).toBe(2);
});
expect(globalDrawersWrapper.findActiveDrawers()[0].getElement()).toHaveTextContent('local-drawer');
expect(globalDrawersWrapper.findActiveDrawers()[1].getElement()).toHaveTextContent('global drawer content 2');
});
Expand Down
2 changes: 1 addition & 1 deletion src/app-layout/__tests__/runtime-drawers.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ describe('toolbar mode only features', () => {

await delay();

expect(wrapper.findDrawersTriggers()!.length).toBe(4);
expect(wrapper.findDrawersTriggers().length).toBe(4);
expect(wrapper.find(`.${toolbarStyles['group-divider']}`)!.getElement()).toBeInTheDocument();
expect(globalDrawersWrapper.findActiveDrawers()!.length).toBe(3);
expect(globalDrawersWrapper.findDrawerById('local-drawer')!.getElement()).toHaveTextContent(
Expand Down

0 comments on commit af49dab

Please sign in to comment.