Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit data attributes #219

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Remove explicit data attributes #219

merged 1 commit into from
Mar 30, 2023

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Mar 24, 2023

Description

Refactor to follow our convention to prefer using scoped class names instead of data-attributes

Related links, issue #, if available: n/a

How has this been tested?

  • PR build
  • See the preview deployment
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris changed the base branch from main to add-jest-dom March 24, 2023 13:52
Base automatically changed from add-jest-dom to main March 28, 2023 11:44
@just-boris just-boris marked this pull request as ready for review March 28, 2023 13:27
@just-boris just-boris requested a review from a team as a code owner March 28, 2023 13:27
@just-boris just-boris requested review from taheramr and removed request for a team March 28, 2023 13:27
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (16d8029) 93.97% compared to head (c9cb899) 93.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          16       16           
  Lines         730      730           
  Branches      178      178           
=======================================
  Hits          686      686           
  Misses         38       38           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@just-boris just-boris requested review from a team and pan-kot and removed request for taheramr and a team March 28, 2023 13:28
Copy link
Member

@pan-kot pan-kot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@just-boris just-boris merged commit 280b452 into main Mar 30, 2023
@just-boris just-boris deleted the fluid-layout branch March 30, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants