Update Spec to 1.1 and Implement Resize#15
Merged
alakae merged 25 commits intocloudscale-ch:masterfrom Apr 22, 2020
alakae:update
Merged
Update Spec to 1.1 and Implement Resize#15alakae merged 25 commits intocloudscale-ch:masterfrom alakae:update
alakae merged 25 commits intocloudscale-ch:masterfrom
alakae:update
Conversation
- Switch to go mod - Bump csi spec to 1.1.0 - Update cloudscale-go-sdk to latest release.
…-test v2.3.0, I got the version by specifying the commit hash '6931aed'. https://github.com/kubernetes-csi/csi-test/releases/tag/v2.3.0
davidhalter
reviewed
Apr 15, 2020
Contributor
davidhalter
left a comment
davidhalter
left a comment
There was a problem hiding this comment.
There's some minor things. In general it looks pretty good.
The only thing that was a bit annoying was the mixture of code of the 1.1 upgrade and the volume expansion. I guess it would have been easier to have two pull requests, but it's fine.
davidhalter
reviewed
Apr 15, 2020
Contributor
|
One more thing that I thought of: It would be nice if we could test that no data gets lost in a disk resize. However since this is kubernetes code, I guess it's fine to just not test it. Formatting a disk completely instead of a proper resize is a potential risk that we might run into. |
Contributor
Author
|
There is now a check that the UUID of the ext4 filesystem does not change while resizing. |
Contributor
|
LGTM now, thanks! |
|
🏆 |
…_host in the inventory.
- sembump (github.com/jessfraz/junk/sembump) is unsupported by the author and won't build on mac/windows. Make NEW_VERSION explicit. - make ... bump-version manged the low-version on the compatibility table. (cherry picked from commit fb1c08db7fb541b3807479f456306ecc811dd7e7)
# Conflicts: # Makefile
davidhalter
approved these changes
Apr 22, 2020
Contributor
Author
|
Resolves #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.