Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove deprecated fields notifications #7

Closed
wants to merge 3 commits into from
Closed

fix: remove deprecated fields notifications #7

wants to merge 3 commits into from

Conversation

toketas
Copy link

@toketas toketas commented Jul 28, 2022

@toketas toketas requested review from a team as code owners July 28, 2022 15:21
@toketas toketas requested review from Gowiem and RothAndrew July 28, 2022 15:21
@okgolove
Copy link

Hello @toketas! I believe you should set minimal cloudflare provider version to >=3.20

nitrocode
nitrocode requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @okgolove already commented, please bump the versions.tf in the root of the repo and the examples directory and we can merge this

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode mentioned this pull request Sep 7, 2022
Merged
@nitrocode nitrocode closed this in #6 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode requested changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toketas @okgolove @nitrocode @cloudpossebot