Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account_id to allow module to function #24

Merged
merged 5 commits into from
May 19, 2023
Merged

Add account_id to allow module to function #24

merged 5 commits into from
May 19, 2023

Conversation

JohnShortland
Copy link
Contributor

@JohnShortland JohnShortland commented May 18, 2023

what

  • Added account_id as a variable
  • Added account_id to teh record resource

why

  • Module no longer worked if creating any records
Planning changes with 0 custom hooks...
Error: Missing required argument
on .terraform/modules/zone/main.tf line 23, in resource "cloudflare_zone" "default":
23: resource "cloudflare_zone" "default" {
The argument "account_id" is required, but no definition was found.
Unexpected exit code when planning changes: 1

references

closes #22

@JohnShortland JohnShortland requested review from a team as code owners May 18, 2023 00:32
@JohnShortland JohnShortland requested review from Gowiem and korenyoni May 18, 2023 00:32
README.yaml Show resolved Hide resolved
@aknysh
Copy link
Member

aknysh commented May 18, 2023

@JohnShortland thanks for the PR

please run the following commands locally and commit the changes

make init
make github/init
make readme

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

changes description of variable to suggested one
@JohnShortland
Copy link
Contributor Author

@JohnShortland thanks for the PR

please run the following commands locally and commit the changes

make init
make github/init
make readme

Running these doesn't seem to work, I would expect to see changes afterward.

vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make init
Removing existing build-harness
Cloning https://github.com/cloudposse/build-harness.git#master...
Cloning into 'build-harness'...
remote: Enumerating objects: 156, done.
remote: Counting objects: 100% (156/156), done.
remote: Compressing objects: 100% (130/130), done.
remote: Total 156 (delta 8), reused 83 (delta 4), pack-reused 0
Receiving objects: 100% (156/156), 100.73 KiB | 2.58 MiB/s, done.
Resolving deltas: 100% (8/8), done.
vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make github/init
make: *** No rule to make target 'github/init'.  Stop.
vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make readme
make: *** No rule to make target 'readme'.  Stop.

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

main.tf Outdated Show resolved Hide resolved
@aknysh
Copy link
Member

aknysh commented May 19, 2023

/terraform-fmt

@aknysh
Copy link
Member

aknysh commented May 19, 2023

@JohnShortland sorry again, but to pass the tests, you need to run terraform fmt on all TF code (including the example), and also format/generate README by running the following commands locally from the root of the repo

make init
make github/init
make readme

@JohnShortland
Copy link
Contributor Author

@aknysh Ready for another review, I think I've covered everything now. Thanks for the pointers.

@aknysh
Copy link
Member

aknysh commented May 19, 2023

/terratest

@aknysh
Copy link
Member

aknysh commented May 19, 2023

/terratest

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aknysh aknysh merged commit affde65 into cloudposse:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing a cloudflare_zone resource results in account_id missing from config
2 participants