-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add account_id to allow module to function #24
Conversation
@JohnShortland thanks for the PR please run the following commands locally and commit the changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
changes description of variable to suggested one
Running these doesn't seem to work, I would expect to see changes afterward.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
/terraform-fmt |
@JohnShortland sorry again, but to pass the tests, you need to run
|
@aknysh Ready for another review, I think I've covered everything now. Thanks for the pointers. |
/terratest |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @JohnShortland
what
why
references
closes #22