Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad markup in README.yaml #24

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Fix bad markup in README.yaml #24

merged 4 commits into from
Oct 22, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 20, 2021 •
edited
Loading

what

  • Fix bad markup (unclosed details block) in README.yaml

why

  • Incorrectly hides most of README

@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Oct 20, 2021
@Nuru Nuru requested review from a team as code owners October 20, 2021 05:31
@Nuru Nuru requested review from dotCipher and adamcrews October 20, 2021 05:31
@Nuru Nuru added bugfix Change that restores intended behavior and removed no-release Do not create a new release (wait for additional code changes) labels Oct 22, 2021
@Nuru Nuru changed the title Fix bad markup in README.yaml Correctly extract security group name for tags Oct 22, 2021
@Nuru
Copy link
Contributor Author

Nuru commented Oct 22, 2021

/test all

@Nuru Nuru merged commit 3638d38 into master Oct 22, 2021
@Nuru Nuru deleted the readme-patch branch October 22, 2021 17:36
@Nuru Nuru added no-release Do not create a new release (wait for additional code changes) and removed bugfix Change that restores intended behavior labels Oct 22, 2021
@Nuru Nuru changed the title Correctly extract security group name for tags Fix bad markup in README.yaml Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@adamcrews adamcrews Awaiting requested review from adamcrews adamcrews was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nuru @nitrocode @cloudpossebot