Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow underscores in names #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cornfeedhobo
Copy link

what

  • allow underscores in log group names

why

  • I created a lambda with underscores in the name, which is auto-creating a log group to match, yet the cloudposse lambda module was creating a group without underscores, which was useless.

references

@cornfeedhobo cornfeedhobo requested review from a team as code owners January 12, 2025 20:52
@mergify mergify bot added the triage Needs triage label Jan 12, 2025
@RoseSecurity
Copy link

/terratest

@cornfeedhobo
Copy link
Author

cornfeedhobo commented Jan 17, 2025

I'm force pushing to re-trigger tests

@RoseSecurity
Copy link

/terratest

@cornfeedhobo
Copy link
Author

I have no idea what to do to make this happy. It looks like this is erroring out because of permissions, but ... is this pointed at an instance of localstack or something?

@RoseSecurity
Copy link

Let me talk to the team and see how we can resolve this. Thank you for the contribution!

@goruha
Copy link
Member

goruha commented Jan 30, 2025

/terratest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants